fix(wallet-sdk): convert all urls#1773
Conversation
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
PHOL-DA
left a comment
PHOL-DA
left a comment
There was a problem hiding this comment.
looks good, except one small problem. These changes are not backwards compatible for anything that is exposed through the wallet sdk. This means we effectively can't put these in until a wallet SDK V2.
my suggested approach would be:
extend all the namespaces with string | URL where applicable (or make two variations one that take string and one that take URL and mark the string as @deprecated).
we make a under the hood conversion of string to URL.
My two cents would be to not mark string variant as deprecated. The wallet-sdk is fairly flexible, and I can imagine someone might build a 3rd party app that reads SDK configuration values externally (a JSON file, environment variables, or even some API call). In that case, it would pretty convenient to support plain string URLs so that the developer doesnt have to remap their external config into the SDK constructor and convert types (We should still do URL validation, of course) |
3 participants
No description provided.